Add embedded classification for field initializers#61522
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom May 26, 2022
Merged
Add embedded classification for field initializers#61522CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
Member
|
Thanks :) |
davidwengier
approved these changes
May 26, 2022
Member
davidwengier
left a comment
There was a problem hiding this comment.
Is the following already supported?
[StringSyntax("regex")]
private string goo;
void M()
{
goo = "\d";
}
Contributor
Author
|
@davidwengier Yup! Suppoted and tested. THat's actually the initial case that worked. This is expanding things to the field/prop level as stephen was refactoring to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @stephentoub