Skip to content

Better completions in generic constraints#61335

Merged
CyrusNajmabadi merged 13 commits intodotnet:mainfrom
DoctorKrolic:better-completions-in-generic-constraints
May 24, 2022
Merged

Better completions in generic constraints#61335
CyrusNajmabadi merged 13 commits intodotnet:mainfrom
DoctorKrolic:better-completions-in-generic-constraints

Conversation

@DoctorKrolic
Copy link
Copy Markdown
Contributor

@DoctorKrolic DoctorKrolic commented May 15, 2022

Fixes: #30784

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner May 15, 2022 20:28
@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE labels May 15, 2022
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented May 15, 2022

done with pass.

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented May 16, 2022

Thanks!

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented May 16, 2022

Done with pass.

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented May 18, 2022

Done with pass.

@runfoapp runfoapp bot mentioned this pull request May 18, 2022
Open
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 24, 2022 15:16
@CyrusNajmabadi CyrusNajmabadi merged commit 2452cf5 into dotnet:main May 24, 2022
@ghost ghost added this to the Next milestone May 24, 2022
@DoctorKrolic DoctorKrolic deleted the better-completions-in-generic-constraints branch May 24, 2022 16:53
@DoctorKrolic DoctorKrolic mentioned this pull request May 24, 2022
Merged
@Cosifne Cosifne modified the milestones: Next, 17.3 P2 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genlu genlu Awaiting requested review from genlu

2 more reviewers

@sharwell sharwell sharwell left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@genlu genlu

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

17.3 P2

Development

Successfully merging this pull request may close these issues.

The completion list for generic constraints has strange inclusions and omissions

6 participants

@DoctorKrolic @CyrusNajmabadi @genlu @sharwell @jinujoseph @Cosifne