Do not try to do a smart copy/paste when the paste change is not fully within the string.#61317
Merged
CyrusNajmabadi merged 7 commits intoMay 16, 2022
Merged
Conversation
CyrusNajmabadi
commented
May 13, 2022
CyrusNajmabadi
commented
May 13, 2022
| var stringExpressionBeforePasteFromChanges = TryGetCompatibleContainingStringExpression( | ||
| documentBeforePaste, new NormalizedSnapshotSpanCollection(snapshotBeforePaste, snapshotBeforePaste.Version.Changes.Select(c => c.OldSpan)), cancellationToken); | ||
| if (stringExpressionBeforePaste != stringExpressionBeforePasteFromChanges) | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
this is an additional sanity check which also fixes the issue. I would like both though as we both dont' want to do anything 'smart' if the editor decides to make the edits outside the string and we don't want to do anything smart (for now) with line-copy-paste as it likely needs some though to make sense of what it means with string literals.
sharwell
reviewed
May 14, 2022
sharwell
approved these changes
May 16, 2022
sharwell
left a comment
Contributor
There was a problem hiding this comment.
💡 It would be better to truly support line-copy and line-paste by expanding $$ to the containing line (e.g. to copy a line from inside a @"" string and paste it inside $$""" string), but this is still better than what it does today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61316.