Skip to content

Fix crash when a multi-line raw literal becomes a skipped token.#61312

Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi:virtualCharCrash
May 13, 2022
Merged

Fix crash when a multi-line raw literal becomes a skipped token.#61312
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi:virtualCharCrash

Conversation

@CyrusNajmabadi
Copy link
Contributor

Fixes #61270

@ghost ghost added the Area-IDE label May 13, 2022
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review May 13, 2022 20:44
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 13, 2022 20:44
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this red?
image

@CyrusNajmabadi
Copy link
Contributor Author

what is this red?

Github's c# parser doesn't understand raw string literals :)

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 13, 2022 20:54
@CyrusNajmabadi CyrusNajmabadi merged commit 27e2422 into dotnet:main May 13, 2022
@ghost ghost added this to the Next milestone May 13, 2022
@JoeRobich
Copy link
Member

Github's c# parser doesn't understand raw string literals :)

Which really means that our TextMate Grammar doesn't understand raw string literals dotnet/csharp-tmLanguage#243

@CyrusNajmabadi CyrusNajmabadi deleted the virtualCharCrash branch May 13, 2022 22:33
@CyrusNajmabadi
Copy link
Contributor Author

Oh, i thought they were using tree sitter, not tm. Thanks!

@Cosifne Cosifne modified the milestones: Next, 17.3 P2 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvalidCastException from embedded language bits

4 participants