Skip to content

Show not keyword (and all other stuff) after and & or when they are treated as identifiers#61306

Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
DoctorKrolic:not-after-identifiers
May 15, 2022
Merged

Show not keyword (and all other stuff) after and & or when they are treated as identifiers#61306
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
DoctorKrolic:not-after-identifiers

Conversation

@DoctorKrolic
Copy link
Contributor

@DoctorKrolic DoctorKrolic commented May 13, 2022

Fixes: #61184

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner May 13, 2022 16:15
@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE labels May 13, 2022
@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented May 13, 2022

Can you add tests for expr is (not []) and var x

not should be offered after (, and and should be offered after ). thanks

@DoctorKrolic
Copy link
Contributor Author

DoctorKrolic commented May 13, 2022

@CyrusNajmabadi Test with not passed, so I included it. Test with and didn't. I feel like it is a separate issue and it should be fixed in other PR

@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented May 14, 2022

I feel like it is a separate issue and it should be fixed in other PR

Are you ok if I push to this branch @DoctorKrolic ?

@DoctorKrolic
Copy link
Contributor Author

DoctorKrolic commented May 14, 2022

@CyrusNajmabadi Ok. Still don't understand, why you want it to be fixed here anyway...

@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented May 14, 2022

I'd prefer to take care of these issues all in one go since we're looking in this space anyways. It's more efficient that way vs having to come back at some random point in the future and page all this code in. Thanks!

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 14, 2022 22:52
@CyrusNajmabadi CyrusNajmabadi merged commit 7c7da86 into dotnet:main May 15, 2022
@ghost ghost added this to the Next milestone May 15, 2022
@DoctorKrolic DoctorKrolic deleted the not-after-identifiers branch May 15, 2022 07:51
DoctorKrolic
DoctorKrolic commented May 15, 2022
View reviewed changes
src/EditorFeatures/CSharpTest2/Recommendations/AndKeywordRecommenderTests.cs
expr is (not []) $$");
}

[WorkItem(51431, "https://github.com/dotnet/roslyn/issues/51431")]
Copy link
Contributor Author

@DoctorKrolic DoctorKrolic May 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CyrusNajmabadi Is this WorkItem right? I am not sure. The same in the test above

@DoctorKrolic DoctorKrolic mentioned this pull request May 16, 2022
Merged
@Cosifne Cosifne modified the milestones: Next, 17.3 P2 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@sharwell sharwell sharwell left review comments

@Neme12 Neme12 Neme12 left review comments

@Youssef1313 Youssef1313 Youssef1313 left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

17.3 P2

Development

Successfully merging this pull request may close these issues.

not not appearing after and/or in pattern.

6 participants

@DoctorKrolic @CyrusNajmabadi @sharwell @Neme12 @Youssef1313 @Cosifne