Update dependency versions for 4.2.0 publishing#61265
Merged
333fred merged 7 commits intodotnet:release/dev17.2from May 13, 2022
Merged
Update dependency versions for 4.2.0 publishing#61265333fred merged 7 commits intodotnet:release/dev17.2from
333fred merged 7 commits intodotnet:release/dev17.2from
Conversation
Updates our nuget versions for 4.2.0, so that all published binaries will depend on publicly-available non-prerelease packages. As part of this, I had to break add multiple versions of MSBuild, as Microsoft.VisualStudio.Shell.15.0 is now advertising their dependency on MSBuild 17.1.0. There was always an indirect dependency there, but it was not included in their nuspec.
JoeRobich
approved these changes
May 12, 2022
sharwell
reviewed
May 12, 2022
sharwell
previously approved these changes
May 12, 2022
jaredpar
requested changes
May 12, 2022
Member
jaredpar
left a comment
There was a problem hiding this comment.
netcoreapp3.1 is an out of support runtime. We should not be complicating our build to support it. Literally every other .NET team is removing this TF. We should not be the outlier because it will long term result in us hacking our build over and over again.
This reverts commit a262f14.
333fred
commented
May 12, 2022
| <OutputType>Library</OutputType> | ||
| <RootNamespace>Microsoft.CodeAnalysis</RootNamespace> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <TargetFrameworks>netcoreapp3.1;net472</TargetFrameworks> |
Member
Author
There was a problem hiding this comment.
Source changes in this project are to deal with newly annotated APIs.
Withdrawing approval due to removal of a previously supported TFM, which has always been extremely frustrating to me as a user
genlu
approved these changes
May 12, 2022
Member
Are we considering the move from 3.1 to .Net 6 in main? |
jaredpar
approved these changes
May 12, 2022
jaredpar
reviewed
May 12, 2022
jaredpar
approved these changes
May 12, 2022
Member
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates our nuget versions for 4.2.0, so that all published binaries will depend on publicly-available non-prerelease packages. As part of this, I had to break add multiple versions of MSBuild, as Microsoft.VisualStudio.Shell.15.0 is now advertising their dependency on MSBuild 17.1.0. There was always an indirect dependency there, but it was not included in their nuspec.