Skip to content

EditorFeatures.Cocoa: Bump macos workload to RC3#61250

Merged
sandyarmstrong merged 6 commits intomainfrom
dev/sandy/macos-rc3
Jun 8, 2022
Merged

EditorFeatures.Cocoa: Bump macos workload to RC3#61250
sandyarmstrong merged 6 commits intomainfrom
dev/sandy/macos-rc3

Conversation

@sandyarmstrong
Copy link
Copy Markdown
Member

@sandyarmstrong sandyarmstrong commented May 11, 2022

No description provided.

@ghost ghost added the Area-IDE label May 11, 2022
@sandyarmstrong
Copy link
Copy Markdown
Member Author

sandyarmstrong commented May 11, 2022

This probably requires a corresponding change in the editor to resolve inconsistencies caused by the workload assembly changing from Xamarin.Mac.dll to Microsoft.macOS.dll.

@sandyarmstrong
Copy link
Copy Markdown
Member Author

sandyarmstrong commented May 16, 2022

No idea what this is about:

##[error]src\VisualStudio\VisualBasic\Impl\LanguageService\VisualBasicPackage.vb(60,29): error BC30456: (NETCORE_ENGINEERING_TELEMETRY=Build) 'ComAggregate' is not a member of 'Microsoft.VisualStudio.Interop'.

@sandyarmstrong
Copy link
Copy Markdown
Member Author

sandyarmstrong commented May 16, 2022

@sharwell @genlu any idea about this 'ComAggregate' is not a member of 'Microsoft.VisualStudio.Interop' error? I don't think I can avoid bumping editor/shell/etc to 17.3.

sharwell
sharwell reviewed May 18, 2022
View reviewed changes
Comment thread eng/Versions.props Outdated
sandyarmstrong
sandyarmstrong commented May 18, 2022
View reviewed changes
Comment thread eng/Versions.props Outdated
sandyarmstrong and others added 3 commits May 18, 2022 07:18
@sandyarmstrong
EditorFeatures.Cocoa: Bump macos workload to RC3
6247dac
@sandyarmstrong
Cocoa needs System.Runtime.Interop.Services.NFloat.Internal now
6059afc 
This comes in automatically when targeting `net6.0-macos`, but since we
reference those packages manually, we have to reference this one
manually too.
@sandyarmstrong
Use a different property for Mac-specific editor package version
16c120d 
Bump to a newer editor build for EditorFeatures.Cocoa.
@sandyarmstrong sandyarmstrong marked this pull request as ready for review May 18, 2022 14:27
@sandyarmstrong sandyarmstrong requested a review from a team as a code owner May 18, 2022 14:27
@sandyarmstrong sandyarmstrong requested a review from a team May 18, 2022 14:27
@sandyarmstrong sandyarmstrong requested a review from a team as a code owner May 18, 2022 14:27
@sandyarmstrong
Copy link
Copy Markdown
Member Author

sandyarmstrong commented May 18, 2022

@davidwengier this can merge at any time, but we don't want to insert it until VSMac is done bumping to 6.0.300 SDK.

@davidwengier
Copy link
Copy Markdown
Member

davidwengier commented May 18, 2022

Thanks @sandyarmstrong, I'm subscribed to https://github.com/xamarin/vsmac/pull/7247 to keep an eye on that.

@sandyarmstrong
Copy link
Copy Markdown
Member Author

sandyarmstrong commented May 19, 2022

I notice the merge button is enabled even though Build Analysis and roslyn-integration-corehost are failing (I tried rerunning them). Is it OK if I merge?

@davidwengier
Copy link
Copy Markdown
Member

davidwengier commented May 19, 2022 •
edited
Loading

Yes, corehost tests aren't blocking yet, as they're not stable.

Either way "but GitHub let me" is a totally valid excuse if you're not an admin 😁

@davidwengier davidwengier mentioned this pull request May 24, 2022
Merged
@sandyarmstrong sandyarmstrong merged commit 17b90d9 into main Jun 8, 2022
@sandyarmstrong sandyarmstrong deleted the dev/sandy/macos-rc3 branch June 8, 2022 00:15
@ghost ghost added this to the Next milestone Jun 8, 2022
@RikkiGibson RikkiGibson removed this from the Next milestone Jun 28, 2022
@RikkiGibson RikkiGibson added this to the 17.3 P3 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

+1 more reviewer

@sharwell sharwell sharwell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

17.3 P3

Development

Successfully merging this pull request may close these issues.

4 participants

@sandyarmstrong @davidwengier @sharwell @RikkiGibson