Skip to content

Test the EditorFeatures layer on net472 and net6.0-windows#61234

Closed
sharwell wants to merge 10 commits intodotnet:mainfrom
sharwell:wpf-net6
Closed

Test the EditorFeatures layer on net472 and net6.0-windows#61234
sharwell wants to merge 10 commits intodotnet:mainfrom
sharwell:wpf-net6

Conversation

@sharwell
Copy link
Copy Markdown
Contributor

@sharwell sharwell commented May 10, 2022 •
edited
Loading

@ghost ghost added the Area-IDE label May 10, 2022
@sharwell
Update Microsoft.CodeAnalysis.CSharp.EditorFeatures.UnitTests to targ…
fdb10c5 
…et net6.0-windows

Also update Microsoft.CodeAnalysis.CSharp.EditorFeatures2.UnitTests,
which was split from the above.
@sharwell sharwell marked this pull request as ready for review May 13, 2022 22:37
@sharwell sharwell requested a review from a team as a code owner May 13, 2022 22:37
@sharwell sharwell requested a review from a team May 13, 2022 22:37
@sharwell sharwell requested review from a team as code owners May 13, 2022 22:37
JoeRobich
JoeRobich approved these changes May 13, 2022
View reviewed changes
src/EditorFeatures/TestUtilities/Workspaces/TestWorkspace.cs
=> GetTestProject(documentId.ProjectId);

public TestHostProject GetTestProject(ProjectId projectId)
public TestHostProject? GetTestProject(ProjectId projectId)
Copy link
Copy Markdown
Member

@JoeRobich JoeRobich May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add GetRequired versions of these?

@sharwell sharwell mentioned this pull request May 25, 2022
Merged
@genlu genlu linked an issue Jun 2, 2022 that may be closed by this pull request
Targeting IDE layer projects to .Net Core #45534
Closed
@runfoapp runfoapp bot mentioned this pull request Jul 27, 2022
Open
@genlu genlu mentioned this pull request Oct 7, 2022
Merged
@arunchndr arunchndr added this to the 17.5 P2 milestone Oct 7, 2022
@arunchndr arunchndr modified the milestones: 17.5 P2, 17.5 P3 Dec 30, 2022
@genlu
Copy link
Copy Markdown
Member

genlu commented Apr 26, 2023

@sharwell Could we revive this PR? Now our OOP is running on .NET 6, there's a big gap in our test coverage.

@genlu
Copy link
Copy Markdown
Member

genlu commented Apr 27, 2023

I see the following errors in the correctness build log, but not in other legs. I'm curious why is that (I don't really know what correctness legs are for)? @jaredpar

Processing Solution D:\a\_work\1\s/Roslyn.sln ... FAILED
Processing Microsoft.CodeAnalysis.CSharp.EditorFeatures.UnitTests.csproj
TargetFramework net6.0-windows8.0 is not supported in this build

Processing Microsoft.CodeAnalysis.CSharp.EditorFeatures2.UnitTests.csproj
TargetFramework net6.0-windows8.0 is not supported in this build

Processing Microsoft.CodeAnalysis.EditorFeatures.UnitTests.csproj
TargetFramework net6.0-windows8.0 is not supported in this build

@jaredpar
Copy link
Copy Markdown
Member

jaredpar commented Apr 28, 2023

I see the following errors in the correctness build log, but not in other legs

This particular check is to ensure we don't accidentally add new TFM into our builds. It's less of a problem now but a few years ago we had a real problem with random TFM getting added into our builds that should never have been a part of the product. It took some time to unwind that. Now we have a check that ensures we are notified when new TFM are added to the build.

This is similar to how we have public API files. It's not wrong to add a new public API but we want to make sure it's a very visible process.

Simply add the TFM here

I don't really know what correctness legs are for

These are jobs that ensure our repository is building correctly and in the manner we expect. Think of it as unit test for how we build. This covers everything from build style up to actual build correctness (ensure no double writes, bootstrap hosting, anaylzers, etc ...)

@arunchndr arunchndr modified the milestones: 17.5 P3, Backlog Sep 12, 2023
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented Dec 1, 2024

Moving to draft as this pull request hasn't gone anywhere.

@CyrusNajmabadi CyrusNajmabadi marked this pull request as draft December 1, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar left review comments

@genlu genlu genlu left review comments

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees

No one assigned

Labels

Area-IDE

Projects

Compiler: Julien's umbrellas
Archived in project

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Targeting IDE layer projects to .Net Core

7 participants

@sharwell @genlu @jaredpar @CyrusNajmabadi @JoeRobich @jcouv @arunchndr