Skip to content

[release/dev17.0-vs-deps] Update dependencies from dotnet/arcade#61144

Merged
JoeRobich merged 21 commits intorelease/dev17.0-vs-depsfrom
darc-release/dev17.0-vs-deps-e0b4ca26-1f06-4af7-a64c-cbf21a87cdc2
Jun 7, 2022
Merged

[release/dev17.0-vs-deps] Update dependencies from dotnet/arcade#61144
JoeRobich merged 21 commits intorelease/dev17.0-vs-depsfrom
darc-release/dev17.0-vs-deps-e0b4ca26-1f06-4af7-a64c-cbf21a87cdc2

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro bot commented May 5, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 059d41e3-5449-49d0-f30d-08d9a488296d
  • Build: 20220606.1
  • Date Produced: June 6, 2022 1:55:52 PM UTC
  • Commit: 7f522f2e42fd8c2064afb45eac34a1773ce6a1cc
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
9602dab 
…504.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22254.2
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner May 5, 2022 12:49
ghost
ghost approved these changes May 5, 2022
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

@ghost ghost added the Area-Infrastructure label May 5, 2022
dotnet-maestro bot added 3 commits May 7, 2022 12:49
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
793767c 
…505.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22255.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
afdf3aa 
…509.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22259.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
508e4cc 
…510.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22260.2
@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented May 11, 2022

@epananth We are seeing failures in two of our test legs that validate our build output.

  Generating SBOM manifest
  Specify which project file to use because this 'D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22260.2\tools' contains more than one project file.
D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22260.2\tools\VisualStudio.InsertionManifests.targets(23,5): error MSB3073: The command "D:\a\_work\1\s\.dotnet\dotnet.exe D:\a\_work\1\s\.packages\microsoft.manifesttool.crossplatform\2.1.3\Content\Microsoft.ManifestTool.dll generate -b D:\a\_work\1\s\artifacts\Vsix\Unpacked\ExpressionEvaluatorPackage -m D:\a\_work\1\s\artifacts\sbom\ExpressionEvaluatorPackage -pn VsInsertion -V Verbose" exited with code 1. [D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22260.2\tools\AfterSigning.proj]
##[error].packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22260.2\tools\VisualStudio.InsertionManifests.targets(23,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Sign) The command "D:\a\_work\1\s\.dotnet\dotnet.exe D:\a\_work\1\s\.packages\microsoft.manifesttool.crossplatform\2.1.3\Content\Microsoft.ManifestTool.dll generate -b D:\a\_work\1\s\artifacts\Vsix\Unpacked\ExpressionEvaluatorPackage -m D:\a\_work\1\s\artifacts\sbom\ExpressionEvaluatorPackage -pn VsInsertion -V Verbose" exited with code 1.

Build FAILED.

I believe this may be related to your recent SBOM changes. Is there a way to get more details about what is causing the ManifestTool to fail?

@epananth
Copy link
Copy Markdown
Member

epananth commented May 11, 2022

Yes, I need to add one bit for this to pass.. Will get that done today..

@epananth epananth mentioned this pull request May 11, 2022
Closed
2 tasks
dotnet-maestro bot added 2 commits May 12, 2022 12:49
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
83deb7d 
…511.14

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22261.14
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
5cb2da4 
…511.16

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22261.16
@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented May 12, 2022

@epananth Seeing what I think are different errors now during our integration test builds.

  Generating manifest for VS component 'Microsoft.CodeAnalysis.Compilers'
  Generating manifest for VS component 'Microsoft.CodeAnalysis.LanguageServices'
C:\Users\cloudtest\.nuget\packages\microsoft.visualstudioeng.microbuild.plugins.swixbuild\1.1.269\build\Microsoft.VisualStudioEng.MicroBuild.Plugins.SwixBuild.targets(41,3): error MSB4018: The "AddSBOM" task failed unexpectedly. [C:\Users\cloudtest\.nuget\packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22261.16\tools\VisualStudio.SetupPackage.vsmanproj]
C:\Users\cloudtest\.nuget\packages\microsoft.visualstudioeng.microbuild.plugins.swixbuild\1.1.269\build\Microsoft.VisualStudioEng.MicroBuild.Plugins.SwixBuild.targets(41,3): error MSB4018: System.IO.FileNotFoundException: No package manifest file exists at 'D:\a\_work\1\s\artifacts\VSSetup\Debug\Insertion\Microsoft.CodeAnalysis.LanguageServices.json. Please see https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/26284/Enabling-SBOM-For-Your-Component-Insertion?anchor=enabling-sbom-in-your-microbuild-component-insertion for additional information.' [C:\Users\cloudtest\.nuget\packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22261.16\tools\VisualStudio.SetupPackage.vsmanproj]
C:\Users\cloudtest\.nuget\packages\microsoft.visualstudioeng.microbuild.plugins.swixbuild\1.1.269\build\Microsoft.VisualStudioEng.MicroBuild.Plugins.SwixBuild.targets(41,3): error MSB4018:    at Microsoft.VisualStudioEng.MicroBuild.SwixBuild.AddSBOM.Execute() in D:\a\_work\1\s\src\Plugins\SwixBuild\AddSBOM.cs:line 68 [C:\Users\cloudtest\.nuget\packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22261.16\tools\VisualStudio.SetupPackage.vsmanproj]
C:\Users\cloudtest\.nuget\packages\microsoft.visualstudioeng.microbuild.plugins.swixbuild\1.1.269\build\Microsoft.VisualStudioEng.MicroBuild.Plugins.SwixBuild.targets(41,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [C:\Users\cloudtest\.nuget\packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22261.16\tools\VisualStudio.SetupPackage.vsmanproj]
C:\Users\cloudtest\.nuget\packages\microsoft.visualstudioeng.microbuild.plugins.swixbuild\1.1.269\build\Microsoft.VisualStudioEng.MicroBuild.Plugins.SwixBuild.targets(41,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [C:\Users\cloudtest\.nuget\packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22261.16\tools\VisualStudio.SetupPackage.vsmanproj]
##[error]C:\Users\cloudtest\.nuget\packages\microsoft.visualstudioeng.microbuild.plugins.swixbuild\1.1.269\build\Microsoft.VisualStudioEng.MicroBuild.Plugins.SwixBuild.targets(41,3): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Sign) The "AddSBOM" task failed unexpectedly.
System.IO.FileNotFoundException: No package manifest file exists at 'D:\a\_work\1\s\artifacts\VSSetup\Debug\Insertion\Microsoft.CodeAnalysis.LanguageServices.json. Please see https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/26284/Enabling-SBOM-For-Your-Component-Insertion?anchor=enabling-sbom-in-your-microbuild-component-insertion for additional information.'
   at Microsoft.VisualStudioEng.MicroBuild.SwixBuild.AddSBOM.Execute() in D:\a\_work\1\s\src\Plugins\SwixBuild\AddSBOM.cs:line 68
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

Build FAILED.

@epananth
Copy link
Copy Markdown
Member

epananth commented May 12, 2022

Yes fixing it now.. I created a flag to turn off sbom generation, looks like I need to set that flag here too.. Working on it!

JoeRobich and others added 7 commits May 12, 2022 17:26
@JoeRobich
Generate VS SBOM during official builds.
3605f08
@JoeRobich
Validate nuget feed
4e1e0d9
@JoeRobich
Merge branch 'release/dev17.0-vs-deps' into darc-release/dev17.0-vs-d…
1c53817 
…eps-e0b4ca26-1f06-4af7-a64c-cbf21a87cdc2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
e4281f7 
…512.8

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22262.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
c6c808a 
…516.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22266.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
36f0601 
…519.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22269.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
3d37d01 
…523.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22273.1
@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented May 24, 2022

This PR is currently blocked by dotnet/arcade#9325 (comment).

dotnet-maestro bot and others added 8 commits May 25, 2022 13:12
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
ba3c08a 
…524.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22274.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
0718a44 
…525.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22275.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
940a54f 
…526.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22276.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
1ad87f3 
…530.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22280.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
4c969fe 
…531.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22281.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
e7c5cab 
…601.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22301.2
@JoeRobich
Do not build VS SBOM until Arcade supports it
8f5d284
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
48b976b 
…606.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22225.6 -> To Version 7.0.0-beta.22306.1
@JoeRobich JoeRobich merged commit 8fc71a4 into release/dev17.0-vs-deps Jun 7, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-release/dev17.0-vs-deps-e0b4ca26-1f06-4af7-a64c-cbf21a87cdc2 branch June 7, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoeRobich @epananth