Add support for implementing static members in derived interfaces.#61134
Merged
AlekseyTs merged 2 commits intodotnet:features/DefaultInterfaceImplementationfrom May 10, 2022
Conversation
Contributor
Author
Contributor
Author
|
@jcouv, @dotnet/roslyn-compiler For the second review. |
jcouv
reviewed
May 9, 2022
| } | ||
|
|
||
| if (((!hasBody && IsAbstract) || IsVirtual) && IsStatic && !ContainingAssembly.RuntimeSupportsStaticAbstractMembersInInterfaces) | ||
| if (((!hasBody && IsAbstract) || IsVirtual) && !isExplicitInterfaceImplementation && IsStatic && !ContainingAssembly.RuntimeSupportsStaticAbstractMembersInInterfaces) |
Member
Contributor
Author
There was a problem hiding this comment.
Do we need the additional parameter given that we have
IsExplicitInterfaceImplementationproperty (used in this method already)?
Good catch, I will follow up on this in a separate PR.
jcouv
reviewed
May 9, 2022
Member
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (iteration 2)
Member
|
The spec probably needs updating to reflect decisions as opposed to options: https://github.com/dotnet/csharplang/blob/main/proposals/static-abstracts-in-interfaces.md#default-implementations |
jcouv
approved these changes
May 9, 2022
Member
jcouv
left a comment
There was a problem hiding this comment.
LTGM Thanks (iteration 2). Extra parameter can be removed in later PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/csharplang/blob/main/proposals/static-abstracts-in-interfaces.md
Test plan: #60968
Tests in DefaultInterfaceImplementationTests.cs are adjusted only for methods. Tests for other members will be adjusted separately.