Skip to content

Update Tools|Options code ordering to match waht is in the UI#61110

Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:toolsOptions
May 3, 2022
Merged

Update Tools|Options code ordering to match waht is in the UI#61110
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:toolsOptions

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 3, 2022 20:27
@ghost ghost added the Area-IDE label May 3, 2022
return false;
});

BindToOption(Split_string_literals_on_enter, SplitStringLiteralOptions.Enabled, LanguageNames.CSharp);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super frustrated with having to maintain this code and figure out where things should go. now the order of hte code matches the order of hte groups and items in the xaml.

BindToOption(Always_use_default_symbol_servers_for_navigation, MetadataAsSourceOptionsStorage.AlwaysUseDefaultSymbolServers);
BindToOption(Navigate_asynchronously_exerimental, FeatureOnOffOptions.NavigateAsynchronously);

// Using Directives
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group titles in xaml are marked in code now, to easily match up.

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 3, 2022 20:31
@CyrusNajmabadi CyrusNajmabadi merged commit e0c44fd into dotnet:main May 3, 2022
@ghost ghost added this to the Next milestone May 3, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the toolsOptions branch May 3, 2022 22:02
@Cosifne Cosifne modified the milestones: Next, 17.3 P2 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants