[LSP] Null check semantic tokens workspace capability#61047
Merged
allisonchou merged 1 commit intodotnet:mainfrom Apr 29, 2022
Merged
[LSP] Null check semantic tokens workspace capability#61047allisonchou merged 1 commit intodotnet:mainfrom
allisonchou merged 1 commit intodotnet:mainfrom
Conversation
dibarbet
approved these changes
Apr 29, 2022
ryzngard
approved these changes
Apr 29, 2022
Member
|
@allisonchou: thanks for the fix! Is there a bug on the platform here that the capabilities property isn't annotated as nullable? It seems like everything there should be, right, since that's how capabilities would generally work? |
Contributor
Author
|
@jasonmalinowski Yep you're right, it looks like the other capabilities are marked as nullable. Just filed an issue - https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1533478 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client didn't implement this capability until 17.3 so the
SemanticTokensworkspace capability returns null in 17.2 and prior. This breaks F5'ing in Roslyn for external contributors.I think this simple fix should do the trick, currently installing latest preview to confirm.