Treat some nint/nuint conversions as standard conversions#61034
Treat some nint/nuint conversions as standard conversions#61034jcouv merged 5 commits intodotnet:mainfrom
Conversation
|
|
||
| // Notice that there is no implicit numeric conversion from a type to itself. That's an | ||
| // identity conversion. | ||
| private static readonly bool[,] s_implicitNumericConversions = |
There was a problem hiding this comment.
To assist with review of the removed tables, here's the portion table from ConversionEasyOut relevant to numeric types:
d391fe9 to
55ed6ee
Compare
I do not see https://github.com/dotnet/csharplang/blob/main/proposals/csharp-9.0/native-integers.md#conversions mention the word "standard" anywhere. What am I missing. |
|
It is not clear to me whether this is a bug fix or a feature work. If this is a bug fix, what is the corresponding tracking issue? |
|
Done with review pass (commit 3) |
|
@AlekseyTs This is a bug fix (thus done in
|
| } | ||
|
|
||
| #nullable enable | ||
| private static bool HasImplicitNumericConversion(TypeSymbol source, TypeSymbol destination) |
| using System; | ||
| using System.Collections.Immutable; | ||
| using System.Linq; | ||
| using System.Runtime.CompilerServices; |
There was a problem hiding this comment.
Interesting. This using wasn't used, but also wasn't grayed out in IDE.
See https://github.com/dotnet/csharpstandard/blob/draft-v7/standard/conversions.md#1042-standard-implicit-conversions
For reference: https://github.com/dotnet/csharplang/blob/main/proposals/csharp-9.0/native-integers.md#conversions
This was found in context of numeric IntPtr work (test plan #60578) but affects native ints feature (test plan #38821)