Emit ObsoleteAttribute for required member constructors#61005
Merged
333fred merged 3 commits intodotnet:features/required-membersfrom Apr 28, 2022
Merged
Emit ObsoleteAttribute for required member constructors#61005333fred merged 3 commits intodotnet:features/required-membersfrom
333fred merged 3 commits intodotnet:features/required-membersfrom
Conversation
Support emitting ObsoleteAttribute on the constructor of types with required members. Specification: https://github.com/dotnet/csharplang/blob/main/proposals/required-members.md Test plan: dotnet#57046
Member
Author
|
@jcouv @RikkiGibson for review. |
Member
|
Looks like there are legitimate test failures |
Member
Author
|
@jcouv please take another look. |
jcouv
reviewed
Apr 28, 2022
jcouv
reviewed
Apr 28, 2022
src/Compilers/CSharp/Test/Symbol/Symbols/RequiredMembersTests.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Apr 28, 2022
jcouv
reviewed
Apr 28, 2022
jcouv
approved these changes
Apr 28, 2022
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (iteration 2) with a couple of nits to consider
Member
Author
|
@RikkiGibson for a second review. |
RikkiGibson
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support emitting ObsoleteAttribute on the constructor of types with required members.
Specification: https://github.com/dotnet/csharplang/blob/main/proposals/required-members.md
Test plan: #57046