[LSP] Remove semantic tokens IsFinalized logic#60993
Merged
allisonchou merged 1 commit intodotnet:release/dev17.3from Apr 28, 2022
Merged
[LSP] Remove semantic tokens IsFinalized logic#60993allisonchou merged 1 commit intodotnet:release/dev17.3from
allisonchou merged 1 commit intodotnet:release/dev17.3from
Conversation
dibarbet
approved these changes
Apr 27, 2022
| { | ||
| // If the project's compilation isn't yet available, kick off a task in the background to | ||
| // hopefully make it available faster since we'll need it later to compute tokens. | ||
| var newCompilationTask = project.GetCompilationAsync(cancellationToken); |
Contributor
Author
There was a problem hiding this comment.
Actually, I don't think we need the linked PR. Razor already removed caching and the isFinalized logic from their end, so keeping it wouldn't have any effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Razor switched over to workspace/semanticTokens/refresh messages this sprint,
IsFinalizedshould no longer be necessary since we'll send a refresh notification when the compilations are available.