Fix exceptions for non-VS hosting of Roslyn#60979
Merged
davidwengier merged 1 commit intodotnet:mainfrom Apr 27, 2022
Merged
Conversation
davidwengier
commented
Apr 27, 2022
| [SuppressMessage("RoslynDiagnosticsReliability", "RS0033:Importing constructor should be [Obsolete]", Justification = "Used in test code")] | ||
| public PdbSourceDocumentLoaderService( | ||
| [Import(AllowDefault = true)] Lazy<ISourceLinkService?> sourceLinkService, | ||
| [Import(AllowDefault = true)] Lazy<ISourceLinkService?>? sourceLinkService, |
Member
Author
There was a problem hiding this comment.
This was just incorrect. VS Mac doesn't have an implementation of this service (yet!), so this would null ref
Member
There was a problem hiding this comment.
@davidwengier Should this be Lazy<ISourceLinkService>? instead? Because I don't see how you the lazy could return a null if we're allowing the lazy itself to be null?
Member
Author
There was a problem hiding this comment.
ahh good point. That is probably how this bug slipped in, the question mark was just put in the wrong place.
davidwengier
commented
Apr 27, 2022
|
|
||
| static FileStream? ReadFileIfExists(string fileName) | ||
| { | ||
| if (File.Exists(fileName)) |
Member
Author
There was a problem hiding this comment.
PEReader handled the FileNotFoundException fine, but the first chance exception is very common, so easy enough to avoid it.
KirillOsenkov
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60908
First chance exceptions are a little more noticeable in other IDEs.