Skip to content

Store incremental data in AVL tree instead of array#60900

Merged
sharwell merged 1 commit intodotnet:mainfrom
sharwell:incremental-data
Apr 25, 2022
Merged

Store incremental data in AVL tree instead of array#60900
sharwell merged 1 commit intodotnet:mainfrom
sharwell:incremental-data

Conversation

@sharwell
Copy link
Copy Markdown
Contributor

@sharwell sharwell commented Apr 22, 2022

Fixes AB#1487613

@sharwell sharwell requested a review from a team as a code owner April 22, 2022 01:07
@ghost ghost added the Area-IDE label Apr 22, 2022
@genlu
Copy link
Copy Markdown
Member

genlu commented Apr 25, 2022

I don't know anything about the access pattern of this object. Would the switch of data structure cause any perf regressions?

@sharwell
Copy link
Copy Markdown
Contributor Author

I don't know anything about the access pattern of this object

The primary operations are:

  1. Add item to end of list
  2. Replace last item at end of list
  3. Remove first item in list

I believe the new data structure is strictly better for this pattern.

@sharwell sharwell enabled auto-merge April 25, 2022 19:27
Copy link
Copy Markdown
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good RPS wise, just wanna make sure you are aware of it @dibarbet

@sharwell sharwell merged commit 8a27685 into dotnet:main Apr 25, 2022
@ghost ghost added this to the Next milestone Apr 25, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
@sharwell sharwell deleted the incremental-data branch April 29, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants