private ConversionKind[] kinds;

readonly

In reply to: 1105964941

Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs:7290 in 5a2ad5e. [](commit_id = 5a2ad5e, deletion_comment = False)

        public static ExpectedConversion Identity = ConversionKind.Identity;

readonly for each of the static fields.

In reply to: 1105965012

Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs:7292 in 5a2ad5e. [](commit_id = 5a2ad5e, deletion_comment = False)

        public void AssertMatches(Conversion conversion)

Consider calling this bool Equals(Conversion) and let the caller assert, so that this helper class is independent of the test framework.

In reply to: 1105968021

In reply to: 1105968021

Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs:7327 in 5a2ad5e. [](commit_id = 5a2ad5e, deletion_comment = False)

        public void AssertMatches(Conversion conversion)

It's actually better to assert here, because the Assert.Equal on enumerables prints out the actual list. Since I'm going to re-use this helper for new tests, that'll be helpful.

In reply to: 1105968021

Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs:7327 in 5a2ad5e. [](commit_id = 5a2ad5e, deletion_comment = False)

    internal class ExpectedConversion

Could we use Conversion (or ConversionKind) directly rather than introducing a new type?

In reply to: 1105977264

Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs:7288 in 5a2ad5e. [](commit_id = 5a2ad5e, deletion_comment = False)

    internal class ExpectedConversion

I don't mind. Switched to ConversionKind[]

In reply to: 1105977264

Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs:7288 in 5a2ad5e. [](commit_id = 5a2ad5e, deletion_comment = False)

using System.Diagnostics;

Is this used?

Refers to: src/Compilers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs:21 in f26191f. [](commit_id = f26191f, deletion_comment = False)