Update simplify-type-names to understand global imports.#60872
Merged
CyrusNajmabadi merged 77 commits intodotnet:mainfrom Apr 29, 2022
Merged
Update simplify-type-names to understand global imports.#60872CyrusNajmabadi merged 77 commits intodotnet:mainfrom
CyrusNajmabadi merged 77 commits intodotnet:mainfrom
Conversation
…i/roslyn into compilationImports
…n unspecified order of arrays.
davidwengier
approved these changes
Apr 29, 2022
| private static ImmutableHashSet<string> GetAliasedNames(CompilationUnitSyntax? compilationUnit) | ||
| private ImmutableHashSet<string> GetAliasedNames(CompilationUnitSyntax compilationUnit) | ||
| { | ||
| var aliasedNames = s_emptyAliasedNames; |
Member
There was a problem hiding this comment.
Not sure the static makes sense any more. Could probably switch to a builder
Contributor
Author
There was a problem hiding this comment.
changed to pooled set.
| } | ||
| } | ||
|
|
||
| foreach (var usingDirective in compilationUnit.Usings) |
Member
There was a problem hiding this comment.
Are these not already included because of the above? or does position 0 in GetImportScopes mean it only returns the global usings?
Contributor
Author
There was a problem hiding this comment.
yeah, this will pull in the other global usings, it doesn't pull in the usings for the using block we're in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59042
Followup to #59533.