Remove unused method Binder.CheckViability<TSymbol>()#60865
Merged
RikkiGibson merged 1 commit intomainfrom Apr 21, 2022
Merged
Conversation
Youssef1313
reviewed
Apr 20, 2022
Member
Youssef1313
left a comment
There was a problem hiding this comment.
In case you want to do more cleanup.
ExecutableCodeBinder.MemberSymbolproperty is unused.LookupOptionExtensions.CanConsiderTypesextension method is unsued.IsTypeExpressionOpen(in TypeofBinder for C#, and GetTypeBinder for VB)HasReferenceDirectivesmethods (in CSharpExtensions and VisualBasicExtensions)GetSubmissionInitializerin both CSharpCompilation and VisualBasicCompilation- Maybe a lot more.
Note: The work above for those unused members isn't mine. I'm filtering what's valid from #17630
cston
approved these changes
Apr 20, 2022
Member
Author
Thank you for suggesting these. I don't anticipate addressing more dead code here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.