Skip to content

Avoid artificial tagging delay when called by consumer that is explicitly blocking for results.#60830

Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:blockingTagCAll
Apr 19, 2022
Merged

Avoid artificial tagging delay when called by consumer that is explicitly blocking for results.#60830
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:blockingTagCAll

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

Reported by @chuckries. Found during investigation of F12 scenario, which was slowed down because it collapses outlining regions prior to file being visible, and blocks on that operation happening.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 19, 2022 00:03
@ghost ghost added the Area-IDE label Apr 19, 2022
@chuckries
Copy link
Copy Markdown
Contributor

I verified this fix locally; can confirm that F12 + Source Link is much more responsive, no longer hitting consistent 3s delay.

@davkean
Copy link
Copy Markdown
Member

davkean commented Apr 19, 2022

Nice one!

@CyrusNajmabadi CyrusNajmabadi merged commit e162905 into dotnet:main Apr 19, 2022
@ghost ghost added this to the Next milestone Apr 19, 2022
@jinujoseph
Copy link
Copy Markdown
Contributor

cc @davidwengier for info

@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the blockingTagCAll branch May 3, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants