Exclude System.Text.Encoding.CodePages from OptProf#60827
Merged
genlu merged 2 commits intodotnet:release/dev16.11-vs-depsfrom Apr 19, 2022
Merged
Exclude System.Text.Encoding.CodePages from OptProf#60827genlu merged 2 commits intodotnet:release/dev16.11-vs-depsfrom
genlu merged 2 commits intodotnet:release/dev16.11-vs-depsfrom
Conversation
JoeRobich
approved these changes
Apr 18, 2022
Member
|
We should consider adding an exclude for this file in our CI and Integration CI, similar to https://github.com/dotnet/roslyn/blob/main/azure-pipelines-integration.yml#L21. |
Member
Author
|
@JoeRobich Done! #60828 |
Member
|
@genlu do we have / need QB approval for the insertion? |
Member
Author
|
Hmm, maybe? I think it's needed for test only change as well. I can send it for approval once the PR is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dibarbet This is to fix an OptProf profiling issue https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1515514
Once merged, we will need an 16.11 insertion with OptProf config update only (i.e. dotnet.roslyn.props file in VS)