@DoctorKrolic Answered on Discord. Thanks! :)

@CyrusNajmabadi please review

@CyrusNajmabadi I checked failing integration tests and found out, that IsUnusedLocalDiagnostic will be reported for all unused local nodes, e.g.:

class Program
{
  public static void Main()
  {
    var x = new Program();
  }
}

x will have IsUnusedLocalDiagnostic tag, but codefix will produce this code:

class Program
{
  public static void Main()
  {
    var _ = new Program();
  }
}

So the decision of whether should node be removed or changed to discard is fully implemented in codefixe's code. This method replaces all declaration patterns with type declarations:

var a = "str";
if (a is object obj)
{
}

declaration pattern object obj will be changed to just type declaration object

Considering this fact, I reverted logic of PR back to just checking for declaration pattern when deciding what codefix title to show

@CyrusNajmabadi PTAL

Thanks :)