Remove IDynamicFileInfo-added syntax trees to attempt to improve perf#60531
Merged
jasonmalinowski merged 1 commit intodotnet:release/dev17.2from Apr 11, 2022
Conversation
2e6f2b3 to
22160e9
Compare
sharwell
approved these changes
Apr 4, 2022
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.CompilationTracker.cs
Show resolved
Hide resolved
Member
Author
|
Marking this as ready for review; and writing up the QB side of things; my intent is still to get a unit test added before merging. |
davidwengier
approved these changes
Apr 8, 2022
Member
davidwengier
left a comment
There was a problem hiding this comment.
If we define dynamic files as being files that don't get passed to generators, then this isn't a hack!
Member
Author
|
@davidwengier A bit of a retcon, but sure, I'll take it. 😄 |
This is a tactical hack which aims to address some of the CPU overhead that we were seeing in dotnet#59818. Closes dotnet#59818
22160e9 to
fb7998f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tactical hack which aims to address some of the CPU overhead that we were seeing in #59818.
Closes #59818