Conversation
allisonchou
left a comment
There was a problem hiding this comment.
Has it been confirmed that f5 doesn't break in public preview builds? (I can try it out later if no one has yet)
50fdd06 to
89b1bd9
Compare
|
Currently merge doesn't build because a property was removed from the |
3469df4 to
23f2062
Compare
@allisonchou I did some light C# work in an f5 session and nothing was broken. |
| ITextViewRoleSet previewRoleSet, | ||
| IGlobalOptionService globalOptions) | ||
| { | ||
| threadingContext.ThrowIfNotOnUIThread(); |
There was a problem hiding this comment.
Why this change?
Currently all preview window integration tests are failing because they are hitting this assert (this is not being called from the UI thread). I removed the assert as we didn't appear to need it for this ctor.
Why are we hitting this only in this PR?
- Cyrus merged a change in main-vs-deps which changed the behavior here to throw if not on the UI thread when previously it only asserted a UI thread existed (per Sam's comment here)
- This passed all PR checks originally because it was being called on the UI thread in main-vs-deps.
- However, a recent change in main modified this to no longer be called on the UI thread.
- So now when we merge, the assert (from main-vs-deps) throws because its no longer on the UI thread (from main). Fun!
1160a11 to
c8ebc86
Compare
No description provided.