Enable NRT in AbstractSyncNamespaceCodeRefactoringProvider#60492
Merged
genlu merged 1 commit intodotnet:mainfrom Apr 1, 2022
Merged
Enable NRT in AbstractSyncNamespaceCodeRefactoringProvider#60492genlu merged 1 commit intodotnet:mainfrom
genlu merged 1 commit intodotnet:mainfrom
Conversation
allisonchou
approved these changes
Mar 31, 2022
| return null; | ||
|
|
||
| var position = span.Start; | ||
| if (await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false) is not CompilationUnitSyntax compilationUnit) |
Contributor
There was a problem hiding this comment.
if we're exported for LangNamesd.CSharp, this should always work, right? can you se GetRequiredSyntaxRootASync?
| /// </summary> | ||
| private static bool IsDocumentPathRootedInProjectFolder(Document document) | ||
| { | ||
| var absoluteDircetoryPath = PathUtilities.GetDirectoryName(document.FilePath); |
Member
There was a problem hiding this comment.
I was hoping you'd fix the spelling :) dircetory -> directory
Member
Author
There was a problem hiding this comment.
Ah, I missed that. Will fix
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60270
Fixes #54363