Merged
Conversation
jmarolf
commented
Mar 29, 2022
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFrameworks>net6.0</TargetFrameworks> | ||
| <TargetFrameworks>net6.0-windows</TargetFrameworks> |
Contributor
Author
There was a problem hiding this comment.
Because this reference does not target netstandard or net6.0 I needed to change the tfm to be windows only for now
Member
|
Do you also need to update the |
JoeRobich
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several dependencies that are set to
PrivateAssets="all"inMicrosoft.CodeAnalysis.EditorFeatureshere:roslyn/src/EditorFeatures/Core/Microsoft.CodeAnalysis.EditorFeatures.csproj
Lines 36 to 46 in f690017
We need to deploy these so we can properly reflect over
Microsoft.CodeAnalysis.EditorFeaturesand discover the set of codefixes and refactorings we ship and compute the telemetry hashes for them.