Initial work to move indentation services down to codestyle layer (step 4/N)#60442
Merged
CyrusNajmabadi merged 10 commits intodotnet:mainfrom Mar 29, 2022
Merged
Initial work to move indentation services down to codestyle layer (step 4/N)#60442CyrusNajmabadi merged 10 commits intodotnet:mainfrom
CyrusNajmabadi merged 10 commits intodotnet:mainfrom
Conversation
mavasani
reviewed
Mar 29, 2022
...ces/SharedUtilitiesAndExtensions/Compiler/CSharp/Formatting/CSharpSyntaxFormattingService.cs
Show resolved
Hide resolved
mavasani
reviewed
Mar 29, 2022
src/Workspaces/Core/Portable/Indentation/FormattingOptions.IndentStyle.cs
Show resolved
Hide resolved
mavasani
reviewed
Mar 29, 2022
...aces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/FormattingOptions2.IndentStyle.cs
Show resolved
Hide resolved
mavasani
reviewed
Mar 29, 2022
...Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/ISyntaxFormattingService.cs
Show resolved
Hide resolved
mavasani
reviewed
Mar 29, 2022
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Indentation/IndentationOptions.cs
Show resolved
Hide resolved
mavasani
reviewed
Mar 29, 2022
src/Workspaces/VisualBasic/Portable/Formatting/VisualBasicSyntaxFormattingService.vb
Show resolved
Hide resolved
mavasani
reviewed
Mar 29, 2022
src/Workspaces/VisualBasic/Portable/Microsoft.CodeAnalysis.VisualBasic.Workspaces.vbproj
Show resolved
Hide resolved
mavasani
reviewed
Mar 29, 2022
...ces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/AbstractSyntaxFormattingService.cs
Show resolved
Hide resolved
mavasani
reviewed
Mar 29, 2022
...ces/SharedUtilitiesAndExtensions/Compiler/CSharp/Formatting/CSharpSyntaxFormattingService.cs
Show resolved
Hide resolved
mavasani
approved these changes
Mar 29, 2022
Contributor
mavasani
left a comment
There was a problem hiding this comment.
LGTM, mostly nits.
Every time i try to tackle the general problem, it explodes into a ton of changes.
I can feel your pain, I ran into the same things when trying to move analyzers/fixers down to these shared layers. Thanks for breaking it up into different PRs!
Contributor
Author
yup yup. i had to do it in tiny bits. but it all worked out in the end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #60440
This continues that work by pushing ISmartTokenFormatter down to the codestyle layer.
I'm doing these PRs in multiple parts to make things simpler to review. Every time i try to tackle the general problem, it explodes into a ton of changes.
The reason for this change overall is that we have fixers taht need to know indentation information. For example, the 'convert to file-scoped-namespace (and reverse)' fixes have to know indentation information so it can make the right fixes. Not having indentation info be available at thsi level means that the fixes are constrained to the VS host.