Skip to content

Support adding new assembly level attributes with SyntaxGenerator when some already exist in the document#60425

Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
jkoritzinsky:syntaxgen-multiple-assembly-attrs
Mar 29, 2022
Merged

Support adding new assembly level attributes with SyntaxGenerator when some already exist in the document#60425
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
jkoritzinsky:syntaxgen-multiple-assembly-attrs

Conversation

@jkoritzinsky
Copy link
Copy Markdown
Member

Fixes #60399

@jkoritzinsky jkoritzinsky requested a review from a team as a code owner March 28, 2022 20:39
@ghost ghost added the Area-IDE label Mar 28, 2022
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

Thanks!

@jkoritzinsky
Copy link
Copy Markdown
Member Author

Test failure is #57423. Can we manually merge this in, or do we need to wait for the test to get fixed?

@CyrusNajmabadi CyrusNajmabadi merged commit 496bf63 into dotnet:main Mar 29, 2022
@ghost ghost added this to the Next milestone Mar 29, 2022
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 30, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SyntaxGenerator.AddAttributes does not add assembly: target if there are already assembly attributes in the file

4 participants