Move tests to different assembly to address combined string length issue#60395
Merged
jcouv merged 4 commits intodotnet:mainfrom Mar 27, 2022
Merged
Move tests to different assembly to address combined string length issue#60395jcouv merged 4 commits intodotnet:mainfrom
jcouv merged 4 commits intodotnet:mainfrom
Conversation
Contributor
|
Is touching files under Semantics necessary? I would prefer to not split that folder. |
Contributor
Author
Yes. that file references one of the types that moved to the other project. |
CyrusNajmabadi
commented
Mar 26, 2022
| { | ||
| public class PatternMatchingTest5 | ||
| { | ||
| public class FlowAnalysisTests : FlowTestBase |
Contributor
Author
There was a problem hiding this comment.
needed to move because this test reference FlowTestBase
CyrusNajmabadi
commented
Mar 26, 2022
| } | ||
|
|
||
| /// <remarks>Ported from <see cref="FlowTests.IfConditionalConstant" />.</remarks> | ||
| // <remarks>Ported from <see cref="FlowTests.IfConditionalConstant" />.</remarks> |
Contributor
Author
There was a problem hiding this comment.
needed to edit these as the crefs reference the flow tests which just moved.
JoeRobich
approved these changes
Mar 27, 2022
RikkiGibson
approved these changes
Mar 27, 2022
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can help with the merge into 17.3: #60314