Skip to content

Add feature to convert from top-level-statements to Program.Main form#60383

Merged
JoeRobich merged 69 commits intodotnet:mainfrom
CyrusNajmabadi:programMain
Apr 6, 2022
Merged

Add feature to convert from top-level-statements to Program.Main form#60383
JoeRobich merged 69 commits intodotnet:mainfrom
CyrusNajmabadi:programMain

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi commented Mar 25, 2022 •
edited
Loading

Comes with style option: csharp_style_prefer_top_level_statements

Looks like:

image

Todo:

  • Provide way to go from Program.Main to top-level-statements
  • Provide refactoring on top of fixer to go the other direction if the style is there, but set to hidden
  • Have the new-file generation code respect this option if present.

@ghost ghost added the Area-IDE label Mar 25, 2022
Youssef1313
Youssef1313 reviewed Mar 25, 2022
View reviewed changes
Youssef1313
Youssef1313 reviewed Mar 25, 2022
View reviewed changes
src/Features/CSharp/Portable/ConvertProgram/ConvertProgramCodeFixProvider.cs
namespace Microsoft.CodeAnalysis.CSharp.ConvertProgram
{
[ExportCodeFixProvider(LanguageNames.CSharp, Name = PredefinedCodeFixProviderNames.ConvertToProgramMain), Shared]
internal class ConvertToProgramMainCodeFixProvider : SyntaxEditorBasedCodeFixProvider
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be in Analyzers layer.

Copy link
Copy Markdown
Contributor Author

@CyrusNajmabadi CyrusNajmabadi Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches the ConvertNamespace fixer work. we can move both over at the same time if appropriate.

Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CyrusNajmabadi This causes bugs like #45569

There are many codefixes that are misplaced in Features. I think it's better if future codefixes are placed properly making the future work to move everything to Analyzers more manageable.

Copy link
Copy Markdown
Contributor Author

@CyrusNajmabadi CyrusNajmabadi Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, i'm amenable to that, but i think ti should be done as a general work item that also ensures that the analyzer/fixer layer has all the appropraite other extensions/modules needed to make that work.

CyrusNajmabadi and others added 4 commits March 25, 2022 11:16
@CyrusNajmabadi @Youssef1313
Update src/Analyzers/CSharp/Analyzers/CSharpAnalyzers.projitems
6ecd6f1 
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@CyrusNajmabadi
Simplify
18b531a
@CyrusNajmabadi
Merge branch 'programMain' of https://github.com/CyrusNajmabadi/roslyn …
7039b08 
…into programMain
@CyrusNajmabadi @Youssef1313
Update src/Analyzers/CSharp/Analyzers/ConvertProgram/ConvertToProgram…
4eef1a0 
…MainDiagnosticAnalyzer.cs

Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

CyrusNajmabadi commented Mar 28, 2022

Perhaps a test or two with a file that has a file header, just to make sure that is maintained?

Will do!

@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Mar 28, 2022
Merged
@JoeRobich JoeRobich merged commit 0de15bb into dotnet:main Apr 6, 2022
@ghost ghost added this to the Next milestone Apr 6, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the programMain branch April 7, 2022 17:44
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Apr 27, 2022
Closed
@cremor cremor mentioned this pull request Aug 16, 2022
Closed
10 tasks
@RehanSaeed RehanSaeed mentioned this pull request Aug 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

+1 more reviewer

@Youssef1313 Youssef1313 Youssef1313 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE Needs Shiproom Approval

Projects

None yet

Milestone

17.3.P1

Development

Successfully merging this pull request may close these issues.

6 participants

@CyrusNajmabadi @davidwengier @Youssef1313 @JoeRobich @dibarbet @jinujoseph