Fix issue with remove-unnecessary-cast and necessary explicit casts.#60293
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Mar 21, 2022
Merged
Fix issue with remove-unnecessary-cast and necessary explicit casts.#60293CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Mar 21, 2022
| // if the new code would have the same conversion as well. | ||
| if (originalConversionOperation.Parent is IConversionOperation { IsImplicit: true, Conversion: { IsUserDefined: true } } originalParentImplicitConversion) | ||
| if (originalConversionOperation.Parent is IConversionOperation { Conversion.IsUserDefined: true } originalParentConversion && | ||
| originalParentConversion.GetConversion().IsImplicit) |
Contributor
Author
There was a problem hiding this comment.
sigh. boneheaded mistake on my part. IConversionOperation.IsImplicit doesn't mean it's an implciit conversion. THis is .IsImplicit inherited from IOperation (where it means the operation was not written in source).
mavasani
reviewed
Mar 21, 2022
| if (rewrittenConditionalOperation.Parent is IConversionOperation { IsImplicit: true } implicitConversion && | ||
| castType.Equals(implicitConversion.Type, SymbolEqualityComparer.IncludeNullability)) | ||
| if (rewrittenConditionalOperation.Parent is IConversionOperation conditionalParentConversion && | ||
| conditionalParentConversion.GetConversion().IsImplicit && |
Contributor
There was a problem hiding this comment.
How about defining an extension method “IsImplicitConversion” on IConversionOperation? This will likely prevent someone else from making the same mistake when they see IsImplicit and IsImplicitConversion available on it and read through the doc comments on both to choose the appropriate member to invoke.
Contributor
Author
There was a problem hiding this comment.
possibly. though it doesn't help in this case because in a pattern you only see properties :'(
mavasani
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60292