A few improvements to common lightbulb cases.#60251
Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom Mar 18, 2022
Merged
A few improvements to common lightbulb cases.#60251CyrusNajmabadi merged 5 commits intodotnet:mainfrom
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
Conversation
davidwengier
approved these changes
Mar 18, 2022
Member
davidwengier
left a comment
There was a problem hiding this comment.
I could see this going further in future, and just checking if the identifier name starts with the right prefix, though would probably want the other options available in a secondary list in that case. Also if the identifier doesn't start with _ then put generate local first. Just so much bikeshedding potential!
Contributor
Author
|
@davidwengier I completely agree. But I wanted to just make a tiny qol difference here since I was getting so annoyed :-D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After
Deprioritized spell-check fixes, and tweaked 'generate variable' to be better about taking naming into account to not show lots of highly unlikely destination choices.