Remove Name property, make NotificationOption immutable#60245
Merged
tmat merged 2 commits intodotnet:mainfrom Mar 19, 2022
Merged
Remove Name property, make NotificationOption immutable#60245tmat merged 2 commits intodotnet:mainfrom
tmat merged 2 commits intodotnet:mainfrom
Conversation
davidwengier
approved these changes
Mar 18, 2022
Youssef1313
suggested changes
Mar 18, 2022
Member
Youssef1313
left a comment
There was a problem hiding this comment.
I think API breaking changes should be documented in https://github.com/tmat/roslyn/blob/NotificationOption2/docs/Breaking%20API%20Changes.md
Youssef1313
reviewed
Mar 18, 2022
Youssef1313
reviewed
Mar 18, 2022
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CodeStyle/NotificationOption2.cs
Show resolved
Hide resolved
Member
Author
|
Added note to breaking API changes. |
Member
Author
|
/azp run |
|
There was an error handling pipeline event b41aaeda-53ef-424b-8104-27c4b560e828. The command could not be run. |
|
Azure Pipelines failed to run 2 pipeline(s). |
Contributor
|
👍 This was intended to be part of d1d1caf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.