Skip to content

Update NuGet version#60231

Merged
allisonchou merged 1 commit intomainfrom
dev/jorobich/update-nuget
Mar 17, 2022
Merged

Update NuGet version#60231
allisonchou merged 1 commit intomainfrom
dev/jorobich/update-nuget

Conversation

@JoeRobich
Copy link
Copy Markdown
Member

@JoeRobich JoeRobich commented Mar 17, 2022 •
edited
Loading

MSBuildWorkspace tests that run on .NET Core need to have NuGet dependencies that are version matched to those that ship in the SDK pinned by the global.json.

Resolves #60218

@JoeRobich JoeRobich requested a review from a team as a code owner March 17, 2022 17:16
@RikkiGibson
Copy link
Copy Markdown
Member

RikkiGibson commented Mar 17, 2022

Could you please manually run the roslyn-ci job and link the results here, so we can see that the single-machine job is fixed?

Also, do we know why this works on Helix?

@jcouv
Copy link
Copy Markdown
Member

jcouv commented Mar 17, 2022

From chat with @RikkiGibson, it sounds like we expect this to fix flakiness issue #60066. Just want to confirm and link the two.

@JoeRobich
Copy link
Copy Markdown
Member Author

JoeRobich commented Mar 17, 2022

From chat with @RikkiGibson, it sounds like we expect this to fix flakiness issue #60066. Just want to confirm and link the two.

Yes, I expect it to resolve #60066. Thanks for linking me to it.

@JoeRobich
Copy link
Copy Markdown
Member Author

JoeRobich commented Mar 17, 2022

Could you please manually run the roslyn-ci job and link the results here, so we can see that the single-machine job is fixed?

CI: https://dev.azure.com/dnceng/public/_build/results?buildId=1668827&view=results

Also, do we know why this works on Helix?

Not yet.

@allisonchou
Copy link
Copy Markdown
Contributor

allisonchou commented Mar 17, 2022

@JoeRobich I'm going to merge in this PR to unblock the main to main-vs-deps pipeline

@allisonchou allisonchou merged commit 01e272d into main Mar 17, 2022
@allisonchou allisonchou deleted the dev/jorobich/update-nuget branch March 17, 2022 21:54
@ghost ghost added this to the Next milestone Mar 17, 2022
@allisonchou allisonchou mentioned this pull request Mar 17, 2022
Closed
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

+1 more reviewer

@allisonchou allisonchou allisonchou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

17.2.P3

Development

Successfully merging this pull request may close these issues.

Fix Test_Windows_CoreClr_Debug_Single_Machine job

4 participants

@JoeRobich @RikkiGibson @jcouv @allisonchou