Fix symbol-finder crash in mixed C#/TypeScript projects#60173
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Mar 15, 2022
Merged
Fix symbol-finder crash in mixed C#/TypeScript projects#60173CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
| @@ -358,8 +360,7 @@ private static IEnumerable<Project> GetProjectsToExamineWorker( | |||
| // that actually supports compilations. | |||
Member
There was a problem hiding this comment.
Either this comment is wrong, or your removal of the Where is wrong, but I have no idea which
Contributor
Author
There was a problem hiding this comment.
Yes. That's fair.
genlu
reviewed
Mar 14, 2022
| @@ -358,8 +360,7 @@ private static IEnumerable<Project> GetProjectsToExamineWorker( | |||
| // that actually supports compilations. | |||
ryzngard
approved these changes
Mar 14, 2022
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
Would love a short description of what was crashing here :)
Otherwise I think code looks reasonable and test added looks to cover scenario.
genlu
reviewed
Mar 14, 2022
| if (client != null) | ||
| { | ||
| var projectIds = projects?.SelectAsArray(p => p.Id) ?? default; | ||
| var projectIds = projects?.Where(p => RemoteSupportedLanguages.IsSupported(p.Language)).SelectAsArray(p => p.Id) ?? default; |
Member
There was a problem hiding this comment.
Is this required for the fix, or just an optimization?
Contributor
Author
There was a problem hiding this comment.
This is required. Oop doesn't support other languages and crashes trying to find these projects on the other side.
genlu
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1464142