Port encapsulate field tests to new harness#60162
Merged
sharwell merged 3 commits intodotnet:mainfrom Mar 15, 2022
Merged
Conversation
sharwell
commented
Mar 14, 2022
| } | ||
| catch (COMException) | ||
| { | ||
| // Devenv can throw COMExceptions if it's busy when we make DTE calls. |
Contributor
Author
There was a problem hiding this comment.
📝 This block might not be necessary in the new harness, since all UI Automation calls are to the current process. I didn't have time to run validation passes on this hypothesis because I've been focused on fixing (recovering from) the unexpected File Save dialog.
sharwell
commented
Mar 14, 2022
| /// Throws an <see cref="InvalidOperationException"/> if an open dialog with that name cannot be | ||
| /// found. | ||
| /// </summary> | ||
| public static async Task<IUIAutomationElement> GetOpenDialogByIdAsync(JoinableTaskFactory joinableTaskFactory, IntPtr visualStudioHWnd, string dialogAutomationId, CancellationToken cancellationToken) |
Contributor
Author
There was a problem hiding this comment.
📝 We should switch to WPF APIs for dialogs we own, and only use UI Automation for dialogs that might not be in WPF. That can be done later though.
allisonchou
approved these changes
Mar 15, 2022
src/VisualStudio/IntegrationTest/New.IntegrationTests/InfrastructureTests.cs
Outdated
Show resolved
Hide resolved
e7fd2c1 to
1b71ca8
Compare
This was referenced Mar 15, 2022
1b71ca8 to
d68d8ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was observed in a recent failing run on roslyn-integration-CI due to use of light bulb in the old integration test harness.
Also update State Reset to automatically dismiss dialogs remaining from a previous test (e.g. the Save File dialog).
Closes #35701