Keep track of when a file code model is created.#60113
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Mar 11, 2022
Merged
Keep track of when a file code model is created.#60113CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
Contributor
Author
|
@jasonmalinowski can you think of any other places someone might get access to codemodel other than FileCodeModel and CodeFunction.GetXml? |
jasonmalinowski
approved these changes
Mar 11, 2022
Comment on lines
+41
to
+42
| // Keep track that code model was accessed. We want to get a sense of how widespread usage of it still is. | ||
| Logger.Log(FunctionId.CodeModel_FileCodeModel_Create); |
Member
There was a problem hiding this comment.
This should be fine, but note that the file code model objects are long-lived. If your goal is to just to figure out what percentage of sessions use CodeModel, this is fine. If you want to figure out something a bit more precise (like how often is CodeModel used within a sesson), you'll need to put this somewhere else.
Contributor
Author
There was a problem hiding this comment.
just trying to figure out the former. really, what percentage of users hit this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: we already collect information for CodeFunction.GetXml.