Skip to content

Fix NRE in VSTypeScriptGoToDefinitionServiceFactory#60105

Merged
tmat merged 1 commit intodotnet:mainfrom
tmat:FixTSNRE
Mar 11, 2022
Merged

Fix NRE in VSTypeScriptGoToDefinitionServiceFactory#60105
tmat merged 1 commit intodotnet:mainfrom
tmat:FixTSNRE

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Mar 11, 2022

@tmat tmat requested a review from a team as a code owner March 11, 2022 05:22
@ghost ghost added the Area-IDE label Mar 11, 2022
zkat
zkat approved these changes Mar 11, 2022
View reviewed changes
Copy link
Copy Markdown

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds about right!

@tmat tmat merged commit ae86573 into dotnet:main Mar 11, 2022
@tmat tmat deleted the FixTSNRE branch March 11, 2022 16:32
@ghost ghost added this to the Next milestone Mar 11, 2022
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

+1 more reviewer

@zkat zkat zkat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

17.2.P3

Development

Successfully merging this pull request may close these issues.

4 participants

@tmat @zkat @davidwengier @allisonchou