Skip to content

Update LOC branch for 17.2 release#59996

Merged
JoeRobich merged 1 commit intorelease/dev17.1from
dev/jorobich/update-loc-branch-17.2
Mar 7, 2022
Merged

Update LOC branch for 17.2 release#59996
JoeRobich merged 1 commit intorelease/dev17.1from
dev/jorobich/update-loc-branch-17.2

Conversation

@JoeRobich
Copy link
Copy Markdown
Member

No description provided.

@JoeRobich JoeRobich requested a review from a team as a code owner March 7, 2022 19:04
@ghost ghost added the Area-Infrastructure label Mar 7, 2022
@JoeRobich JoeRobich enabled auto-merge March 7, 2022 19:06
Copy link
Copy Markdown
Contributor

@allisonchou allisonchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeRobich this PR is targeted towards release/dev17.1 but the mirror branch is release/dev17.2, is this intentional? I would have expected it to target release/dev17.2, is this just for backporting purposes?

@JoeRobich
Copy link
Copy Markdown
Member Author

@JoeRobich this PR is targeted towards release/dev17.1 but the mirror branch is release/dev17.2, is this intentional? I would have expected it to target release/dev17.2, is this just for backporting purposes?

@allisonchou The reason I targeted 17.1 (and really I could have just targeted 17.1-vs-deps) is that when the 17.1 branch runs it need to know it is no longer the target branch for LOC changes. Otherwise we could get additional LOC PRs opened against it.

Copy link
Copy Markdown
Contributor

@allisonchou allisonchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, that makes sense. Thanks for the explanation 🙂

@JoeRobich
Copy link
Copy Markdown
Member Author

Not a functional change. Merging.

@JoeRobich JoeRobich disabled auto-merge March 7, 2022 21:41
@JoeRobich JoeRobich merged commit 49fd026 into release/dev17.1 Mar 7, 2022
@JoeRobich JoeRobich deleted the dev/jorobich/update-loc-branch-17.2 branch May 9, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants