CSharpImportAdder should be able to add the intended import if the identifier is a var#59947
Merged
akhera99 merged 4 commits intodotnet:mainfrom Mar 7, 2022
Merged
CSharpImportAdder should be able to add the intended import if the identifier is a var#59947akhera99 merged 4 commits intodotnet:mainfrom
akhera99 merged 4 commits intodotnet:mainfrom
Conversation
Member
|
Is this ready to be reviewed? |
Member
Author
haha it can be reviewed, im just going back and fixing tests |
Cosifne
reviewed
Mar 4, 2022
| private void Deconstruct(out object x, out object y) | ||
| { | ||
| throw new System.NotImplementedException(); | ||
| throw new NotImplementedException(); |
Member
There was a problem hiding this comment.
For me this looks fine, but it would be better to check with the original test author to see the old behavior is not by design.
Cosifne
reviewed
Mar 4, 2022
| if (node.IsRightSideOfDotOrArrowOrColonColon()) | ||
| return; | ||
|
|
||
| if (node.IsVar) |
Member
There was a problem hiding this comment.
I see, so from my side I don't see any harm for this check
Contributor
There was a problem hiding this comment.
i would def doc this.
Cosifne
approved these changes
Mar 4, 2022
CyrusNajmabadi
approved these changes
Mar 5, 2022
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Thanks for breaking this into its own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.