Remove unnecessary conditional logic from FlowAnalysisPass#59892
Merged
RikkiGibson merged 1 commit intomainfrom Mar 3, 2022
Merged
Remove unnecessary conditional logic from FlowAnalysisPass#59892RikkiGibson merged 1 commit intomainfrom
RikkiGibson merged 1 commit intomainfrom
Conversation
cston
approved these changes
Mar 2, 2022
Member
Author
|
@dotnet/roslyn-compiler for second review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic was added to ensure that synthesized, non-default struct constructors were flow analyzed to report definite assignment errors. Such constructors no longer exist due to dotnet/csharplang#5552. Therefore there's no longer a need to check for them.
@cston for review.