Skip to content

Exclude object's methods from ref struct completion list#59884

Merged
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
DoctorKrolic:exclude-object-methods-from-ref-structs
Mar 7, 2022
Merged

Exclude object's methods from ref struct completion list#59884
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
DoctorKrolic:exclude-object-methods-from-ref-structs

Conversation

@DoctorKrolic
Copy link
Copy Markdown
Contributor

@DoctorKrolic DoctorKrolic commented Mar 2, 2022

Fixes: #35178

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner March 2, 2022 19:02
@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE labels Mar 2, 2022
@runfoapp runfoapp bot mentioned this pull request Mar 2, 2022
Closed
@DoctorKrolic DoctorKrolic requested a review from a team as a code owner March 3, 2022 20:57
RikkiGibson
RikkiGibson reviewed Mar 3, 2022
View reviewed changes
@RikkiGibson RikkiGibson self-assigned this Mar 3, 2022
@DoctorKrolic DoctorKrolic requested a review from RikkiGibson March 3, 2022 22:10
333fred
333fred requested changes Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented above, I don't believe this should involve changes in the compiler layer.

@DoctorKrolic DoctorKrolic requested a review from 333fred March 4, 2022 18:43
333fred
333fred previously requested changes Mar 4, 2022
View reviewed changes
@DoctorKrolic DoctorKrolic requested a review from 333fred March 4, 2022 19:36
@333fred 333fred dismissed their stale review March 4, 2022 20:20

No more compiler changes.

genlu
genlu approved these changes Mar 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM based on the discussion in this PR. But I'd like to let @CyrusNajmabadi to confirm and merge since he's one originally proposed the alternative solution.

@DoctorKrolic
Copy link
Copy Markdown
Contributor Author

DoctorKrolic commented Mar 7, 2022

@CyrusNajmabadi This PR needs your attention)

CyrusNajmabadi
CyrusNajmabadi approved these changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit 8dd2143 into dotnet:main Mar 7, 2022
@ghost ghost added this to the Next milestone Mar 7, 2022
@DoctorKrolic DoctorKrolic deleted the exclude-object-methods-from-ref-structs branch March 7, 2022 19:21
@DoctorKrolic DoctorKrolic mentioned this pull request Mar 7, 2022
Closed
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
@DoctorKrolic DoctorKrolic mentioned this pull request Apr 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@333fred 333fred 333fred left review comments

@RikkiGibson RikkiGibson RikkiGibson left review comments

@genlu genlu genlu approved these changes

+2 more reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@genlu genlu

@RikkiGibson RikkiGibson

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

17.2.P3

Development

Successfully merging this pull request may close these issues.

IntelliSense suggests GetType on a span, but it won't compile

8 participants

@DoctorKrolic @genlu @333fred @CyrusNajmabadi @RikkiGibson @Youssef1313 @jinujoseph @allisonchou