Ignore documents from projects that do not support EnC when calculating active statements#59839
Merged
tmat merged 1 commit intodotnet:release/dev17.2from Mar 4, 2022
Conversation
…ng active statements
Member
Author
|
@davidwengier PTAL |
jasonmalinowski
approved these changes
Mar 4, 2022
|
|
||
| var project = solution.AddProject("dummy_proj", "dummy_proj", DummyLanguageService.LanguageName); | ||
| var document = project.AddDocument("test", SourceText.From("dummy1")); | ||
| var project = solution.AddProject("dummy_proj", "dummy_proj", designTimeOnly ? LanguageNames.CSharp : DummyLanguageService.LanguageName); |
Member
There was a problem hiding this comment.
I admit it's not terribly obvious to me why designTimeOnly controls both the language and also the flag on the document -- should those being independent be tested as well?
Member
Author
There was a problem hiding this comment.
DesignTimeOnly only matters in C#/VB projects since all docs from other projects are ignored completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59826