only include entry points defined in source#59836
Merged
jmarolf merged 2 commits intodotnet:mainfrom Mar 15, 2022
Merged
Conversation
src/VisualStudio/VisualBasic/Impl/ProjectSystemShim/EntryPointFinder.vb
Outdated
Show resolved
Hide resolved
cbef3a5 to
771e539
Compare
src/VisualStudio/VisualBasic/Impl/ProjectSystemShim/EntryPointFinder.vb
Outdated
Show resolved
Hide resolved
fb8bca8 to
7cce9fe
Compare
JoeRobich
approved these changes
Mar 4, 2022
jasonmalinowski
approved these changes
Mar 4, 2022
|
Gentle ping on this. I see PR is set to auto-merge, but checks haven't passed completely. @jmarolf |
Contributor
Author
|
@melytc integration tests have been on the floor for a week+. I can keep re-running them and hoping they eventually pass. |
Contributor
Author
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| ' Only search source symbols | ||
| visitor.Visit(symbol.ContainingCompilation.SourceModule.GlobalNamespace) | ||
| Return visitor.EntryPoints | ||
| End Function |
Contributor
There was a problem hiding this comment.
it saddens me that we have two different copies of this code in C#/VB :D
CyrusNajmabadi
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59696
In winforms apps on .NET Core we are given a global namespace that contains symbols defined as metadata. This never happened on .NET Framework. We now filter out all symbols not in metadata so we don't show incorrect entry points.