Skip to content

Unify our test artifacts directory to upload more stuff on failure#59822

Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom
jasonmalinowski:upload-more-test-results
Mar 1, 2022
Merged

Unify our test artifacts directory to upload more stuff on failure#59822
jasonmalinowski merged 1 commit intodotnet:mainfrom
jasonmalinowski:upload-more-test-results

Conversation

@jasonmalinowski
Copy link
Copy Markdown
Member

dotnet test sticks file attachments for the run into the TestResults directory, but we had a separate directory xUnitResults for where we were putting screenshots. This unifies the directories so we are uploading everything.

dotnet test sticks file attachments for the run into the TestResults
directory, but we had a separate directory xUnitResults for where we
were putting screenshots. This unifies the directories so we are
uploading everything.
@ghost ghost added the Area-Infrastructure label Feb 28, 2022
inputs:
PathtoPublish: '$(Build.SourcesDirectory)\artifacts\bin\Microsoft.VisualStudio.LanguageServices.IntegrationTests\${{ parameters.configuration }}\net472\xUnitResults'
PathtoPublish: '$(Build.SourcesDirectory)\artifacts\bin\Microsoft.VisualStudio.LanguageServices.IntegrationTests\${{ parameters.configuration }}\net472\TestResults'
ArtifactName: '$(System.JobAttempt)-Screenshots ${{ parameters.configuration }} OOP64_${{ parameters.oop64bit }} OOPCoreClr_${{ parameters.oopCoreClr }} LspEditor_${{ parameters.lspEditor }} $(Build.BuildNumber)'
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to rename the artifact in this case, but just want to see if this works first.

@jasonmalinowski
Copy link
Copy Markdown
Member Author

The run https://dev.azure.com/dnceng/public/_build/results?buildId=1636865&view=results confirmed this successfully uploaded the files we wanted it to.

@jasonmalinowski jasonmalinowski marked this pull request as ready for review March 1, 2022 01:24
@jasonmalinowski jasonmalinowski requested review from a team as code owners March 1, 2022 01:24
@jasonmalinowski jasonmalinowski self-assigned this Mar 1, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Mar 1, 2022
@jasonmalinowski jasonmalinowski merged commit e9b15a1 into dotnet:main Mar 1, 2022
@jasonmalinowski jasonmalinowski deleted the upload-more-test-results branch March 1, 2022 23:40
@ghost ghost added this to the Next milestone Mar 1, 2022
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants