Adjust checklist for merging new compiler feature#59816
Merged
Conversation
jaredpar
reviewed
Mar 1, 2022
| - Completeness of the specification as a guide for testing (is the spec complete enough to suggest what the compiler should do in each scenario?) | ||
| - Other external documentation | ||
| - *Ping* for new breaking changes and general ping for partner teams (Bill, Kathleen, Mads, IDE, Razor) | ||
| - Other external documentation |
Member
There was a problem hiding this comment.
Can we make this more specific?
Help review external documentation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillWagner
approved these changes
Mar 1, 2022
Member
BillWagner
left a comment
There was a problem hiding this comment.
Thanks for updating this @jcouv This LGTM to me. I had one optional suggestion.
| - Completeness of the specification as a guide for testing (is the spec complete enough to suggest what the compiler should do in each scenario?) | ||
| - Other external documentation | ||
| - *Ping* for new breaking changes and general ping for partner teams (Bill, Kathleen, Mads, IDE, Razor) | ||
| - Help review external documentation |
Member
There was a problem hiding this comment.
To @jaredpar 's point, I might clarify that this is our docs, not all 3rd party publiciations:
Suggested change
| - Help review external documentation | |
| - Help review [first party documentation](https://docs.microsoft.com/dotnet/csharp) changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @jaredpar @BillWagner @KathleenDollard @MadsTorgersen