Make solution crawler and diagnostics options global#59800
Merged
tmat merged 5 commits intodotnet:mainfrom Mar 11, 2022
Merged
Conversation
ab78d82 to
986946e
Compare
986946e to
54cbf45
Compare
654c8e6 to
d113a73
Compare
Member
Author
|
@CyrusNajmabadi PTAL |
d113a73 to
eda115f
Compare
CyrusNajmabadi
approved these changes
Mar 9, 2022
src/Features/LanguageServer/Protocol/Features/Options/DiagnosticModeExtensions.cs
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Features/Options/SolutionCrawlerOptionsStorage.cs
Show resolved
Hide resolved
| TokenList); | ||
|
|
||
| public static readonly Option2<string> TokenList = new(nameof(TodoCommentOptions), nameof(TokenList), defaultValue: ""); | ||
| public static readonly TodoCommentOptions Default = new(); |
Contributor
There was a problem hiding this comment.
whihc constructor does this call? :'( this part of the language confuses me.
Member
Author
There was a problem hiding this comment.
Yes, we did not end up in a good spot here with structs. Not sure if this can be fixed, probably not. This will call the explicitly defined parameterless ctor. The one with optional parameters is different one. That's actually why I'm defining the parameterless one so that one does not end up in a trap of calling new T() and ending up with default(T) instead of the default values.
Also, something like this would be useful:
readonly record struct R(optional T X = <expr>); // T must be non-nullable typewhich would translate to:
readonly struct R
{
public readonly T X;
R(T? X = default) { this.X = X ?? <expr>; }
}where <expr> is an arbitrary expression, not limited to constants.
Member
Author
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
7075b6d to
3354e5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Depends on insertions of these changes: