View call hierarchy fix (#57856)#59739
Merged
ryzngard merged 3 commits intodotnet:mainfrom Jun 6, 2022
maciek231:ViewCallHierarchyFix
Merged
View call hierarchy fix (#57856)#59739ryzngard merged 3 commits intodotnet:mainfrom maciek231:ViewCallHierarchyFix
ryzngard merged 3 commits intodotnet:mainfrom
maciek231:ViewCallHierarchyFix
Conversation
added 2 commits
February 24, 2022 18:07
ryzngard
suggested changes
Feb 24, 2022
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
These changes look good overall but I don't see a test verifying the fixed scenario for setters. Thanks for contributing! Once these tests are in and small naming changes we can get these in.
src/VisualStudio/CSharp/Test/CallHierarchy/CSharpCallHierarchyTests.cs
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
|
@maciek231 apologies for the delay here. I assumed this got in after auto merge was enabled, but it was hung up on failing tests and fell off my radar. Rerunning everything now and will make sure this gets in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #57856
Fix view call hierarchy tests. Assertions in methods 'VerifyResult' and 'VerifyResultName' weren't reached, if the specified root had no callers.