Skip to content

Add support for yield return to CompleteStatementCommandHandler#59683

Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
meziantou:issues/54709
Apr 5, 2022
Merged

Add support for yield return to CompleteStatementCommandHandler#59683
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
meziantou:issues/54709

Conversation

@meziantou
Copy link
Copy Markdown
Contributor

Fix #54709

@meziantou meziantou requested a review from a team as a code owner February 22, 2022 01:28
@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE and removed Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Feb 22, 2022
Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and to the point! Thanks.

@davidwengier davidwengier enabled auto-merge (squash) February 22, 2022 02:55
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Feb 22, 2022
@meziantou
Copy link
Copy Markdown
Contributor Author

The CI fails, so the PR cannot be merged. The failure doesn't seem related to my changes. Is there something I can do?

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

@meziantou thanks for letting us know. I'm rerunning tests!

@dotnet dotnet deleted a comment from azure-pipelines bot Apr 5, 2022
@CyrusNajmabadi CyrusNajmabadi merged commit f3d2ec1 into dotnet:main Apr 5, 2022
@ghost ghost added this to the Next milestone Apr 5, 2022
@meziantou meziantou deleted the issues/54709 branch April 5, 2022 22:12
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CompleteStatementCommandHandler should work with yield return

7 participants